Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssm): Generate correct SSM Parameter ARN #1726

Merged
merged 2 commits into from
Feb 12, 2019
Merged

fix(ssm): Generate correct SSM Parameter ARN #1726

merged 2 commits into from
Feb 12, 2019

Commits on Feb 11, 2019

  1. fix(ssm): Generate correct SSM Parameter ARN 

    The SSM parameter name (`resourceName` portion of it's ARN) is required
to start with a `/`, which caused the presence of a doubled `//` in the generated
ARN caused by the fact `sep` defaults to `/`.

This change allows `sep` to be set to an empty string, allowing SSM rendering
of correct SSM parameter ARNs.
    @RomainMuller
    RomainMuller committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    e30e687 View commit details
    Browse the repository at this point in the history

  2. Add unit test

    @RomainMuller
    RomainMuller committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    ed76841 View commit details
    Browse the repository at this point in the history