feat(ecr): add server-side encryption configuration #16966
Conversation
|
|
github-actions
bot
added
the
@aws-cdk/aws-ecr
peterwoodworth
changed the title
|
@madeline-k Do you have some time to review my PR? |
|
This would be a very useful addition indeed! |
|
The rosetta test is pretty nice. Looks like I fixed all issues for now. A review would be very nice. |
There was a problem hiding this comment.
Thank you for opening this PR @Wurstnase! It looks great, just needs a few updates.
mergify
bot
dismissed
madeline-k’s stale review
Pull request has been modified.
|
@madeline-k Thanks for your review. I take your suggestions. I'm currently fighting with my dev container. |
|
Hi @madeline-k , I just fixed all your comments. Please take a look. |
mergify
bot
dismissed
madeline-k’s stale review
Pull request has been modified.
|
@madeline-k This PR should be ready 😀 |
There was a problem hiding this comment.
This looks great, thank you so much @Wurstnase!
Unfortunately, you will probably encounter some merge conflicts when you merge the latest from master now, and will definitely need to update the unit tests. This week, we migrated this module to use the new Assertions unit test framework. The work to update should be minimal and pretty obvious after you merge from master. Let me know if you have questions!
Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
|
As you've said. It wasn't that hard 👍 Thanks alot for your review, @madeline-k. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
* origin/master: (74 commits) chore: remove reliance on `decdk` in build system (aws#18760) chore: add repository directory for all packages.json (aws#17203) docs(ecs): correct comment documentation for NetworkMode (aws#17841) feat(ecs): expose image name in container definition (aws#17793) feat(ecr): add server-side encryption configuration (aws#16966) chore(region-info): ap-southeast-3 (Jakarta) ROUTE_53_BUCKET_WEBSITE_ZONE_ID (aws#18110) chore: reassign njlynch's ownership areas (aws#18751) chore(ecs-service-extensions): migrate tests to assertions (aws#18649) chore(s3): Fixed documentation for `InventoryFormat.ORC` (aws#18717) feat(iot): add Action to republish MQTT messages to another MQTT topic (aws#18661) chore(rds): add support for PostgreSQL 14 (aws#18713) fix(core): correctly reference versionless secure parameters (aws#18730) fix(ec2): `UserData.addSignalOnExitCommand` does not work in combination with `userDataCausesReplacement` (aws#18726) fix(vpc): Vpc.fromLookup should throw if subnet group name tag is explicitly given and does not exist (aws#18714) docs(dynamodb): add note around table encryption (aws#18721) chore: override `markdown-it` version (aws#18723) docs(cfnspec): update CloudFormation documentation (aws#18741) chore(release): 1.142.0 chore(lambda-layer-awscli): contains a CLI version with a CVE (aws#18727) chore(lambda-python): remove Pillow dependency (aws#18722) ...
fixes aws#15400 With this request you will be able to configure the encryption of your ECR Repository. Before this patch you need to use a L1-Construct and add it via: Python: ```python repo = ecr.Repository(stack, 'Repo') cfn_repo = repo.node.default_child cfn_repo.encryption_configuration = CfnRepository.EncryptionConfigurationProperty(encryption_type="KMS") ``` Now this becomes: ```python repo = ecr.Repository(stack, 'Repo', encryption_type=ecr.RepositoryEncryption.KMS) ``` When using a KMS Key, the `encryption_type` is set automatically to `KMS`. ```python kms_key = kms.Key(stack, 'Key') ecr.Repository(stack, 'Repo', encryption_key=kms_key) ``` Similar to aws#15571 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes #15400
With this request you will be able to configure the encryption of your ECR Repository.
Before this patch you need to use a L1-Construct and add it via:
Python:
Now this becomes:
When using a KMS Key, the
encryption_typeis set automatically toKMS.Similar to #15571
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license