Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudfront): support Behavior-specific viewer protocol policy for CloudFrontWebDistribution #16389

Merged
merged 2 commits into from
Sep 30, 2021
Merged

feat(cloudfront): support Behavior-specific viewer protocol policy for CloudFrontWebDistribution #16389

merged 2 commits into from
Sep 30, 2021

Conversation

jiegec
Copy link
Contributor

@jiegec jiegec commented Sep 6, 2021

This pr fixes issue #7086 by allowing user to set viewer protocol policy in Behavior.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 6, 2021

@jiegec
Copy link
Contributor Author

jiegec commented Sep 13, 2021

Fixed the conflict.

@njlynch njlynch changed the title fix(cloudfront): Allow user to override viewer protocol policy in Behavior feat(cloudfront): support Behavior-specific viewer protocol policy for CloudFrontWebDistribution Sep 30, 2021
@njlynch njlynch added the pr-linter/exempt-readme The PR linter will not require README changes label Sep 30, 2021
@njlynch njlynch self-assigned this Sep 30, 2021
njlynch
njlynch approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Looks great!

@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d8340ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5c028c5 into aws:master Sep 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

njlynch pushed a commit that referenced this pull request Oct 11, 2021
@jiegec @njlynch
feat(cloudfront): support Behavior-specific viewer protocol policy fo…
329a82f 
…r CloudFrontWebDistribution (#16389)


This pr fixes issue #7086 by allowing user to set viewer protocol policy in Behavior.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@jiegec @TikiTDO
feat(cloudfront): support Behavior-specific viewer protocol policy fo…
4b2b9ae 
…r CloudFrontWebDistribution (aws#16389)


This pr fixes issue aws#7086 by allowing user to set viewer protocol policy in Behavior.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

Assignees

@njlynch njlynch

Labels
pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiegec @aws-cdk-automation @njlynch