Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve error message in SSMParameterProvider #1630

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

RomainMuller
Copy link
Contributor

When using a non-existent SSM Parameter with the SSMParameterProvider,
the error message null was returned by the toolkit instead of a more
meaningful error mentioning important details such as the parameter name
that was looked up and the account/region where it could not be found.

Fixes #1621

When using a non-existent SSM Parameter with the SSMParameterProvider,
the error message `null` was returned by the toolkit instead of a more
meaningful error mentioning important details such as the parameter name
that was looked up and the account/region where it could not be found.

Fixes #1621
@RomainMuller RomainMuller requested a review from a team as a code owner January 29, 2019 10:46
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would you be interested in adding an integration test for this in cdk-ops?

@RomainMuller RomainMuller merged commit 6a8e010 into master Jan 29, 2019
@RomainMuller RomainMuller deleted the rmuller/fix-1621 branch January 29, 2019 11:27
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message "null" when trying to read the parameter from SSM when it doesn't exist
3 participants