Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk): only make Outputs Exports when necessary #1624

Merged
merged 5 commits into from
Feb 5, 2019
Merged

fix(cdk): only make Outputs Exports when necessary #1624

merged 5 commits into from
Feb 5, 2019

Commits on Jan 28, 2019

  1. fix(cdk): only make Outputs Exports when necessary 

    Export names must be unique and can conflict, so automatically turning
every Output into an Export can lead to problems for customers who
deploy the same template multiple times. Especially when the outputs
are created for them and they have no control over them.

We'll turn Outputs into exports on-demand (when .makeImportValue() is
called).

Fixes #903, fixes #1611.
    Rico Huijbers committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    d7328c6 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. Fix tests and comment

    @rix0rrr
    rix0rrr committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    c3ed241 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Update test expectations

    @rix0rrr
    rix0rrr committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    2c69f49 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into huijbers/no-exports

    @rix0rrr
    rix0rrr committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    94ed07f View commit details
    Browse the repository at this point in the history

  3. Update SSM expectation

    @rix0rrr
    rix0rrr committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    a60699a View commit details
    Browse the repository at this point in the history