fix(cli): Python init template does not work in directory with '-' #15939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Pearcekieser
changed the title
|
Added a test based off the example in similar commit a85da79 |
Pearcekieser
changed the title
peterwoodworth
added
package/tools
rix0rrr
approved these changes
Aug 19, 2021
rix0rrr
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
smguggen
pushed a commit
to smguggen/aws-cdk
that referenced
this pull request
Aug 24, 2021
…ws#15939) fixes aws#15938 Pytest error after init sample-app on directory "aws-data-pipeline" ``` E File "C:\Users\<...>\aws-data-pipeline\tests\unit\test_aws_data_pipe E from aws-data-pipeline.aws_data_pipeline_stack import AwsDataPipelineStack E ^ E SyntaxError: invalid syntax ``` See aws#15938 for detials I was having trouble getting the aws-cdk build and tests running in my dev env. I think its some issues trying to build the code on windows. Do you have any recommendations on how to best add a test for this change? ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…ws#15939) fixes aws#15938 Pytest error after init sample-app on directory "aws-data-pipeline" ``` E File "C:\Users\<...>\aws-data-pipeline\tests\unit\test_aws_data_pipe E from aws-data-pipeline.aws_data_pipeline_stack import AwsDataPipelineStack E ^ E SyntaxError: invalid syntax ``` See aws#15938 for detials I was having trouble getting the aws-cdk build and tests running in my dev env. I think its some issues trying to build the code on windows. Do you have any recommendations on how to best add a test for this change? ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Sep 6, 2021
…ws#15939) fixes aws#15938 Pytest error after init sample-app on directory "aws-data-pipeline" ``` E File "C:\Users\<...>\aws-data-pipeline\tests\unit\test_aws_data_pipe E from aws-data-pipeline.aws_data_pipeline_stack import AwsDataPipelineStack E ^ E SyntaxError: invalid syntax ``` See aws#15938 for detials I was having trouble getting the aws-cdk build and tests running in my dev env. I think its some issues trying to build the code on windows. Do you have any recommendations on how to best add a test for this change? ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
…ws#15939) fixes aws#15938 Pytest error after init sample-app on directory "aws-data-pipeline" ``` E File "C:\Users\<...>\aws-data-pipeline\tests\unit\test_aws_data_pipe E from aws-data-pipeline.aws_data_pipeline_stack import AwsDataPipelineStack E ^ E SyntaxError: invalid syntax ``` See aws#15938 for detials I was having trouble getting the aws-cdk build and tests running in my dev env. I think its some issues trying to build the code on windows. Do you have any recommendations on how to best add a test for this change? ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15938
Pytest error after init sample-app on directory "aws-data-pipeline"
See #15938 for detials
I was having trouble getting the aws-cdk build and tests running in my dev env. I think its some issues trying to build the code on windows. Do you have any recommendations on how to best add a test for this change?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license