Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigatewayv2-integrations): http private integrations - tls config #15469

Merged
merged 8 commits into from
Jul 20, 2021

Conversation

dan-lind
Copy link
Contributor

@dan-lind dan-lind commented Jul 9, 2021

Adds the option to specify tlsConfig for AWS::ApiGatewayV2::Integration resources, to enable use of HTTPS when configuring private integrations.

closes #14036


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 9, 2021

@dan-lind
Copy link
Contributor Author

dan-lind commented Jul 9, 2021

@peterwoodworth I opted to update a unit test in aws-apigatewayv2/test/http/route.test.ts which tested the existing L2 construct. Also added separate tests for the L3 constructs, hope that is fine.

Not entirely clear on why the build failed, works just fine locally.
This looks suspicious though.

Server:
ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

@peterwoodworth
Copy link
Contributor

Where exactly are you getting that build failure?

@dan-lind
Copy link
Contributor Author

dan-lind commented Jul 9, 2021

Where exactly are you getting that build failure?

Check the CodeBuild CI Report above, it says "Result: Failed"

@peterwoodworth
Copy link
Contributor

Oh duh 🤦 right there. I'm not sure why that happened, no idea why you'd get that error there 🤷

@peterwoodworth peterwoodworth self-assigned this Jul 12, 2021
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it works fine. However we could afford to have more abstraction here, right? Why not allow the user to input the property SecureServerName and then have the CDK handle setting the TlsConfig -> ServerNameToVerify property?

@peterwoodworth peterwoodworth added the @aws-cdk/aws-apigatewayv2-integrations Related to AWS APIGatewayv2 Integrations label Jul 12, 2021
@peterwoodworth
Copy link
Contributor

We can deal with the build errors once we're ready to approve. Hopefully it won't happen again but if it does we can figure out how to deal with that

@dan-lind
Copy link
Contributor Author

Agree! I've updated the MR per your suggestion. Let's see if the build passes this time.

@peterwoodworth
Copy link
Contributor

Thank you! It looks good to me, I'll leave it to @nija-at for final review

@nija-at nija-at changed the title feat(apigatewayv2-integrations): add option to specify tlsConfig for L2 and L3 integration constructs feat(apigatewayv2-integrations): http private integrations - tls config Jul 20, 2021
nija-at
nija-at previously approved these changes Jul 20, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@nija-at nija-at added the pr-linter/exempt-readme The PR linter will not require README changes label Jul 20, 2021
@mergify mergify bot dismissed nija-at’s stale review July 20, 2021 15:07

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c9f0306
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6453769 into aws:master Jul 20, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
…ig (aws#15469)

Adds the option to specify tlsConfig for `AWS::ApiGatewayV2::Integration` resources, to enable use of HTTPS when configuring private integrations.

closes aws#14036

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…ig (aws#15469)

Adds the option to specify tlsConfig for `AWS::ApiGatewayV2::Integration` resources, to enable use of HTTPS when configuring private integrations.

closes aws#14036

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigatewayv2-integrations Related to AWS APIGatewayv2 Integrations pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(apigatewayv2-integrations): Set SecureServerName with higher level HTTP API libraries
4 participants