-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigatewayv2-integrations): http private integrations - tls config #15469
Conversation
…L2 and L3 integration constructs
@peterwoodworth I opted to update a unit test in Not entirely clear on why the build failed, works just fine locally.
|
Where exactly are you getting that build failure? |
Check the CodeBuild CI Report above, it says "Result: Failed" |
Oh duh 🤦 right there. I'm not sure why that happened, no idea why you'd get that error there 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it works fine. However we could afford to have more abstraction here, right? Why not allow the user to input the property SecureServerName
and then have the CDK handle setting the TlsConfig -> ServerNameToVerify property?
We can deal with the build errors once we're ready to approve. Hopefully it won't happen again but if it does we can figure out how to deal with that |
Agree! I've updated the MR per your suggestion. Let's see if the build passes this time. |
Thank you! It looks good to me, I'll leave it to @nija-at for final review |
packages/@aws-cdk/aws-apigatewayv2-integrations/lib/http/base-types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 💯
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ig (aws#15469) Adds the option to specify tlsConfig for `AWS::ApiGatewayV2::Integration` resources, to enable use of HTTPS when configuring private integrations. closes aws#14036 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ig (aws#15469) Adds the option to specify tlsConfig for `AWS::ApiGatewayV2::Integration` resources, to enable use of HTTPS when configuring private integrations. closes aws#14036 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds the option to specify tlsConfig for
AWS::ApiGatewayV2::Integration
resources, to enable use of HTTPS when configuring private integrations.closes #14036
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license