fix(pipelines): unable to add assets stage to existing VPC pipeline #15401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VPC Policy for the asset publishing roles is created as a separate policy, which is guaranteed to be created after the role, but not necessarily before it's needed. CodeBuild -- at CloudFormation deploy time -- actually verifies the roles have appropriate permissions, leading to a potential race condition and failure if VPC permissions are not present when the CodeBuild jobs are created. Add an explicit dependency on the separate policy to guarantee creation order during deployment. fixes #14343
|
|
rix0rrr
approved these changes
Jul 5, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
upparekh
pushed a commit
to upparekh/aws-cdk
that referenced
this pull request
Jul 8, 2021
…ws#15401) The VPC Policy for the asset publishing roles is created as a separate policy, which is guaranteed to be created after the role, but not necessarily before it's needed. CodeBuild -- at CloudFormation deploy time -- actually verifies the roles have appropriate permissions, leading to a potential race condition and failure if VPC permissions are not present when the CodeBuild jobs are created. Add an explicit dependency on the separate policy to guarantee creation order during deployment. fixes aws#14343 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…ws#15401) The VPC Policy for the asset publishing roles is created as a separate policy, which is guaranteed to be created after the role, but not necessarily before it's needed. CodeBuild -- at CloudFormation deploy time -- actually verifies the roles have appropriate permissions, leading to a potential race condition and failure if VPC permissions are not present when the CodeBuild jobs are created. Add an explicit dependency on the separate policy to guarantee creation order during deployment. fixes aws#14343 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VPC Policy for the asset publishing roles is created as a separate policy,
which is guaranteed to be created after the role, but not necessarily before
it's needed. CodeBuild -- at CloudFormation deploy time -- actually verifies the
roles have appropriate permissions, leading to a potential race condition and
failure if VPC permissions are not present when the CodeBuild jobs are created.
Add an explicit dependency on the separate policy to guarantee creation order
during deployment.
fixes #14343
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license