feat(cloudwatch): allow arbitrary statistics in Metric and Alarm #15387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport a wider range of statistics
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
madeline-k
added
the
pr-linter/exempt-readme
njlynch
changed the title
njlynch
changed the title
skinny85
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
upparekh
pushed a commit
to upparekh/aws-cdk
that referenced
this pull request
Jul 8, 2021
…#15387) This change maintains the existing logic which parses statistic strings provided by the user for Simple statistics or Percentile statistics, but it also allows for any string to be passed. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
nija-at
reviewed
Jul 16, 2021
Comment on lines
+235
to
+243
| 'metric accepts a variety of statistics'(test: Test) { | ||
| new Metric({ | ||
| namespace: 'Test', | ||
| metricName: 'Metric', | ||
| statistic: 'myCustomStatistic', | ||
| }); | ||
|
|
||
| test.done(); | ||
| }, |
There was a problem hiding this comment.
This test feels insufficient. You should verify that 'myCustomStatistic' is actually used by plugging into an alarm or widget.
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…#15387) This change maintains the existing logic which parses statistic strings provided by the user for Simple statistics or Percentile statistics, but it also allows for any string to be passed. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change maintains the existing logic which parses statistic strings provided by the user for Simple statistics or Percentile statistics, but it also allows for any string to be passed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license