Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elasticsearch): advancedOptions in domain has no effect #15330

Merged
merged 4 commits into from
Jul 23, 2021
Merged

fix(elasticsearch): advancedOptions in domain has no effect #15330

merged 4 commits into from
Jul 23, 2021

Conversation

jumic
Copy link
Contributor

@jumic jumic commented Jun 28, 2021

Property advancedOptions in ElasticSearch domain did have no effect because the assignment was missing.

  • add assignment for advancedOptions to fix issue
  • test cases
  • describe function in readme

Fixes #14067

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 28, 2021

@peterwoodworth peterwoodworth added the @aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service label Jul 6, 2021
peterwoodworth
peterwoodworth previously approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great! Thank you for fixing this oversight

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@BenChaimberg BenChaimberg added the pr/do-not-merge This PR should not be merged at this time. label Jul 7, 2021
@BenChaimberg BenChaimberg self-assigned this Jul 7, 2021
@BenChaimberg BenChaimberg self-requested a review July 7, 2021 15:55
BenChaimberg
BenChaimberg previously requested changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@BenChaimberg BenChaimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add one or more of these to the integ.elasticsearch.ts integration test?

@BenChaimberg BenChaimberg removed the pr/do-not-merge This PR should not be merged at this time. label Jul 23, 2021
@mergify mergify bot dismissed BenChaimberg’s stale review July 23, 2021 21:25

Pull request has been modified.

jumic and others added 2 commits July 23, 2021 23:26
@jumic @BenChaimberg
fix typo

Verified

This commit was signed with the committer’s verified signature.
richardlau Richard Lau
GPG key ID: C43CEC45C17AB93C
Verified
Learn about vigilant mode
56bd145 
Co-authored-by: Ben Chaimberg <youppi3@gmail.com>
@jumic
Merge branch 'master' into elasticsearch-advancedOptions

Verified

This commit was signed with the committer’s verified signature.
richardlau Richard Lau
GPG key ID: C43CEC45C17AB93C
Verified
Learn about vigilant mode
9179d95
@jumic
Copy link
Contributor Author

jumic commented Jul 23, 2021

I added the integration test as requested and changed the readme.

I also hat to change the policy in the integration test. I received the message 'Apply a restrictive access policy to your domain' when I deployed the stack. My changes where not active at this time. I replaced iam.AnyPrincipal()by iam.AccountRootPrincipal() to use a valid policy.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9179d95
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jumic jumic requested a review from BenChaimberg July 23, 2021 22:10
@mergify mergify bot merged commit 81cbfec into aws:master Jul 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
@jumic @TikiTDO
fix(elasticsearch): advancedOptions in domain has no effect (aws#15330)
da39ad1 
Property `advancedOptions` in ElasticSearch domain did have no effect because the assignment was missing.
* add assignment for advancedOptions to fix issue
* test cases
* describe function in readme

Fixes aws#14067

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@jumic @hollanddd
fix(elasticsearch): advancedOptions in domain has no effect (aws#15330)
66bdfd8 
Property `advancedOptions` in ElasticSearch domain did have no effect because the assignment was missing.
* add assignment for advancedOptions to fix issue
* test cases
* describe function in readme

Fixes aws#14067

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenChaimberg BenChaimberg

@peterwoodworth peterwoodworth

Assignees

@BenChaimberg BenChaimberg

Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(elasticsearch): DomainProps.advancedOptions has no effect (doesn't actually set AdvancedOptions)
4 participants
@jumic @aws-cdk-automation @BenChaimberg @peterwoodworth