fix(core): property overrides fail for references #15018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a property override added an IResolvable as the value, it would not be resolved, but instead treated as a CloudFormation object when rendering the resource's properties, which would lead to some weird behavior (the properties of the IResolvable would be merged into the template). This was noticed by a customer using CFN-Include. As a solution, resolve the overrides before merging them with the properties of the resource.
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Jun 8, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
If a property override added an `IResolvable` as the value, it would not be resolved, but instead treated as a CloudFormation object when rendering the resource's properties, which would lead to some weird behavior (the properties of the `IResolvable` would be merged into the template). This was noticed by a customer using CFN-Include. As a solution, resolve the overrides before merging them with the properties of the resource. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a property override added an
IResolvableas the value,it would not be resolved,
but instead treated as a CloudFormation object when rendering the resource's properties,
which would lead to some weird behavior
(the properties of the
IResolvablewould be merged into the template).This was noticed by a customer using CFN-Include.
As a solution, resolve the overrides before merging them with the properties of the resource.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license