chore(eslint-plugin-cdk): fix tests and expectations #12831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous change to add test cases to this package had a bug. Two different eslint rules were being applied simultaneously creating corrupt expectation. Fixing the test so it only runs the specific eslint rule for that fixture, and fixing the expectation.
|
|
eladb
approved these changes
Feb 3, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
The previous change - 9a81faa - to add test cases to this package had a bug. Two different eslint rules were being applied simultaneously creating corrupt expectation. Fixing the test so it only runs the specific eslint rule for that fixture, and fixing the expectation. At the same time, added a test case that was previously missed. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous change - 9a81faa - to add test cases to this package
had a bug. Two different eslint rules were being applied
simultaneously creating corrupt expectation.
Fixing the test so it only runs the specific eslint rule for that
fixture, and fixing the expectation.
At the same time, added a test case that was previously missed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license