Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigateway): cognito user pool authorizer #12786

Merged
merged 6 commits into from
Feb 3, 2021
Merged

feat(apigateway): cognito user pool authorizer #12786

merged 6 commits into from
Feb 3, 2021

Conversation

ayush987goyal
Copy link
Contributor

feat(apigateway): add support for cognito user pool authorizer

closes #5618


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 30, 2021

@github-actions github-actions bot added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Jan 30, 2021
nija-at
nija-at previously requested changes Feb 2, 2021
packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed nija-at’s stale review February 2, 2021 15:11

Pull request has been modified.

@nija-at nija-at changed the title feat(apigateway): add support for cognito user pool authorizer feat(apigateway): cognito user pool authorizer Feb 3, 2021
nija-at
nija-at previously requested changes Feb 3, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments.

@mergify mergify bot dismissed nija-at’s stale review February 3, 2021 10:56

Pull request has been modified.

@ayush987goyal
Copy link
Contributor Author

@nija-at Updated the verification steps.

Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: db6996f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ff1e5b3 into aws:master Feb 3, 2021
@ayush987goyal ayush987goyal deleted the pr/cognito-authorizer branch February 3, 2021 15:33
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
feat(apigateway): add support for cognito user pool authorizer

closes aws#5618 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[apigateway] support cognito user pool authorizer
3 participants