fix(cfn-include): AWS::CloudFormation resources fail in monocdk #12758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we did the changes to fix cloudformation-include in aws#11595, we did not account for the fact that the `@aws-cdk/core` is not mapped to `uberpackage/core`, but instead just to the `uberpackage` root namespace. Special-case the `@aws-cdk/core` module in ubergen when transforming the `cfn-types-2-classes.json` file.
|
|
github-actions
bot
added
the
@aws-cdk/cloudformation-include
nija-at
approved these changes
Jan 31, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
…12758) When we did the changes to fix cloudformation-include in aws#11595, we did not account for the fact that the `@aws-cdk/core` is not mapped to `uberpackage/core`, but instead just to the `uberpackage` root namespace. Special-case the `@aws-cdk/core` module in ubergen when transforming the `cfn-types-2-classes.json` file. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we did the changes to fix cloudformation-include in #11595,
we did not account for the fact that the
@aws-cdk/coreis not mapped touberpackage/core,but instead just to the
uberpackageroot namespace.Special-case the
@aws-cdk/coremodule in ubergen when transforming thecfn-types-2-classes.jsonfile.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license