Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kinesis): Basic stream level metrics #12556

Merged
merged 5 commits into from
May 4, 2021
Merged

feat(kinesis): Basic stream level metrics #12556

merged 5 commits into from
May 4, 2021

Conversation

lgvo
Copy link
Contributor

@lgvo lgvo commented Jan 17, 2021 •
edited by iliapolo
Loading

Closes #12555

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 17, 2021 •
edited
Loading

@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@lgvo lgvo changed the title feat(@aws-cdk/kinesis) - add basic metrics to the Stream (#12555) feat(@aws-cdk/aws-kinesis) - add basic metrics to the Stream (#12555) Jan 17, 2021
@github-actions github-actions bot added the @aws-cdk/aws-kinesis Related to Amazon Kinesis label Jan 17, 2021
@lgvo lgvo changed the title feat(@aws-cdk/aws-kinesis) - add basic metrics to the Stream (#12555) feat(kinesis) - add basic metrics to the Stream (#12555) Jan 17, 2021
@lgvo lgvo changed the title feat(kinesis) - add basic metrics to the Stream (#12555) feat(kinesis): add basic metrics to the Stream (#12555) Jan 17, 2021
@lgvo lgvo mentioned this pull request Jan 17, 2021
Closed
2 tasks
@iliapolo
Copy link
Contributor

iliapolo commented Feb 2, 2021

@lgvo Thanks for this! apologies its taking a while to review. I have it in my queue 👍

iliapolo
iliapolo reviewed Feb 21, 2021
View reviewed changes
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But please add documentation sources to all non canned metrics that you exposed.

packages/@aws-cdk/aws-kinesis/README.md Outdated
You can use common metrics from your stream to create alarms and/or dashboards.
Read more about Kinesis metrics at [Creating and Managing Streams](https://docs.aws.amazon.com/streams/latest/dev/working-with-streams.html)

You can find bellow a example of building a dashboard with the default metrics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, it's a little overwhelming to look at. We don't need to explain how to create dashboards, we just need to mention that metrics are available using stream.metricXXX methods and show an example or two.

@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Feb 21, 2021
@github-actions
Copy link

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Feb 25, 2021
@iliapolo
Copy link
Contributor

@lgvo Are still keeping track of this PR?

@lgvo
Copy link
Contributor Author

lgvo commented Feb 25, 2021

@iliapolo Yes, just too busy with work right now. I'm working on some changes

@iliapolo
Copy link
Contributor

Cool. Keeping this open then 👍

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Feb 26, 2021
@lgvo
Copy link
Contributor Author

lgvo commented Feb 28, 2021

I added kinesis-fixed-canned-metrics.ts to consolidate it all in one place with the reference to source (Kinesis documentation). If at some point the canned metrics are fixed at the source it can just be removed and reference the generated one directly.

Changed the README as well.

@lgvo
Copy link
Contributor Author

lgvo commented Mar 4, 2021

@iliapolo please feel free to ping me on slack, if you have any questions.

@iliapolo iliapolo changed the title feat(kinesis): add basic metrics to the Stream (#12555) feat(kinesis): Stream metrics (#12555) Mar 20, 2021
@iliapolo iliapolo changed the title feat(kinesis): Stream metrics (#12555) feat(kinesis): Stream metrics Mar 20, 2021
@iliapolo iliapolo changed the title feat(kinesis): Stream metrics feat(kinesis): Basic stream level metrics Mar 20, 2021
@mergify
Copy link
Contributor

mergify bot commented May 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@gitpod-io
Copy link

gitpod-io bot commented May 4, 2021

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1bf954b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5f1b576 into aws:master May 4, 2021
@mergify
Copy link
Contributor

mergify bot commented May 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
@lgvo @john-tipper
feat(kinesis): Basic stream level metrics (aws#12556)
bfb7303 
Closes aws#12555 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@lgvo @hollanddd
feat(kinesis): Basic stream level metrics (aws#12556)
f0b0a84 
Closes aws#12555 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

Labels
@aws-cdk/aws-kinesis Related to Amazon Kinesis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(kinesis): Stream metrics
3 participants
@lgvo @iliapolo @aws-cdk-automation