feat(cloudfront): responseHttpStatus defaults to httpStatus in errorResponses #11879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `responseHttpStatus` default to `httpStatus` if `responsePagePath` is defined. This avoids repeating the error code and is more in line with the actual `@default` documentation.
|
|
jogold
changed the title
|
Not sure this requires a README update. |
njlynch
reviewed
Dec 7, 2020
|
|
||
| return this.errorResponses.map(errorConfig => { | ||
| if (!errorConfig.responseHttpStatus && !errorConfig.ttl && !errorConfig.responsePagePath) { | ||
| throw new Error('A custom error response without either a \'responseHttpStatus\' or \'ttl\' is not valid.'); |
There was a problem hiding this comment.
Can you update this error message to be more inline with the new check?
njlynch
added
the
pr-linter/exempt-readme
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
skiyani
pushed a commit
to skiyani/aws-cdk
that referenced
this pull request
Dec 7, 2020
…esponses (aws#11879) Make `responseHttpStatus` default to `httpStatus` if `responsePagePath` is defined. This avoids repeating the error code and is more in line with the actual `@default` documentation (which actually led me to think that it already defaulted to `httpStatus`). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
…esponses (aws#11879) Make `responseHttpStatus` default to `httpStatus` if `responsePagePath` is defined. This avoids repeating the error code and is more in line with the actual `@default` documentation (which actually led me to think that it already defaulted to `httpStatus`). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
responseHttpStatusdefault tohttpStatusifresponsePagePathis defined.
This avoids repeating the error code and is more in line with the actual
@defaultdocumentation (which actually led me to think that italready defaulted to
httpStatus).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license