feat(aws-elasticloadbalancingv2): add metrics #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `metricsXxx()` methods to construct Metric objects for the metrics exposed by Application and Network Load Balancers. Fixes #853.
eladb
approved these changes
Nov 14, 2018
| } | ||
|
|
||
| /** | ||
| * The total number of concurrent TCP connections active from clients to the load balancer and from the load balancer to targets. |
There was a problem hiding this comment.
wrap (I use Rewrap for VSCode, and it's awesomer than life)
| public readonly targetGroupLoadBalancerArns: string[]; | ||
|
|
||
| /** | ||
| * Full name of first load balancer |
There was a problem hiding this comment.
Can you add a comment why would that be useful to a user?
There was a problem hiding this comment.
It's mostly just useful for metrics and for autoscaling (which probably also uses it to access the metrics)
| @@ -0,0 +1,21 @@ | |||
| #!/bin/bash | |||
| # Script to clean stale .js and .d.ts files (that don't have a corresponding .ts | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
metricsXxx()methods to construct Metric objects for the metrics exposedby Application and Network Load Balancers.
Fixes #853.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.