chore: fix Python build of s3-deployent on macOS #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS developers are likely to use a Homebrew Python, which comes with a default pip installation prefix configured. On those systems, running 'pip install --target' leads to the following error: DistutilsOptionError: must supply either home or prefix/exec-prefix — not both Override the system prefix to be empty, and just force pip to install in the given directory.
|
@dstufft this is as far as my understanding goes, but it's fuzzy. Is my reasoning correct or is this "fix" wrong? |
RomainMuller
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS developers are likely to use a Homebrew Python,
which comes with a default pip installation prefix configured.
On those systems, running 'pip install --target' leads to the following
error:
DistutilsOptionError: must supply either home or prefix/exec-prefix — not both
Use
--prefixto override the install prefix, then move the installed packagesto the target location.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.