-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix candidate bump invocation #11318
Conversation
@eladb There was a bug in the changelog skip directive. Even after fixing that, there is an error when running the /private/tmp/aws-cdk/aws-cdk-master/scripts/resolve-version-lib.js:47
throw new Error(`found pre-release tag in version specified in ${versionFile} is ${currentVersion} but "releaseType"" is set to "stable"`);
^
Error: found pre-release tag in version specified in version.v1.json is 1.72.0-rc.0 but "releaseType"" is set to "stable" I imagine we can just disable this check in case its a testing execution? Not sure what the implications of that though. Feel free to take over this branch. |
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Allow versions with pre-release tags in stable branches to allow BUMP_CANDIDATE to work. Otherwise, after the bump, any call to
resolve-version
will fail because there is a mismatch between the actual version andrelease.json
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license