fix(cfnspec): incorrect Route 53 health check configuration properties in CloudFormation specification #11280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in CloudFormation specification The Resource specification import v18.3.0 included unintended specification changes which modified the type of the health check config property and removed the previously modeled HealthCheckConfig type. This patch adds the fix mentioned in to restore the resource specification for Route 53 health checks: #11096 (comment) closes #11096
|
|
shivlaks
added
the
pr-linter/exempt-test
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Nov 4, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2020
…hecks (#11303) The patch added in #11280 was not being applied as our patching requires the `PropertyTypes` and `ResourceTypes` keys rather than use them directly through the `path` property. Since they were previously relying entirely on the path, the patch was not actually applied. Verified the final specification after all patches have been applied. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Resource specification import v18.3.0 included unintended specification changes which modified
the type of the health check config property and removed the previously modeled HealthCheckConfig type.
This patch adds the fix mentioned in to restore the resource specification for Route 53 health checks:
#11096 (comment)
closes #11096
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license