chore: attributions for all bundled third party dependencies #11195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| /** | ||
| * NOTICE files must contain 3rd party attributions | ||
| */ | ||
| export class ThirdPartyAttributions extends ValidationRule { |
There was a problem hiding this comment.
I think this should also check for:
- excessive attributes (e.g: we just removed/replaced a bundled dependency)
- we bundle transitive dependencies, too, so we need to attribute them, too...
And then I'm worried that this ensures that we have some attribution, but doesn't necessarily provide a mechanism to make sure we have correct attribution...
RomainMuller
approved these changes
Oct 29, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute all bundled third party dependencies in the corresponding packages'
NOTICE files along with their license.
Internal ref: tiny/57ei9h5p
Added a 'pkglint' rule that ensures that these are present.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license