chore: build ubergen as part of bump-cfnspec.sh #11191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is transitively required when creating missing libraries in the mono-repository. Use a manual `lerna` invocation instead of `buildup` in order to avoid possibly re-building some dependencies.
|
|
shivlaks
approved these changes
Nov 3, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
shivlaks
added a commit
that referenced
this pull request
Nov 5, 2020
In #11191, we split up the running of the cfnspec update and the adding files to git/commit step into sub-shells However, variable assignments do not remain in effect after the subshell completes. Currently, the `version` variable is not accessible when we try to commit to Git. Removed the execution of these steps in sub-shells as the separation is not likely to provide a ton of benefit.
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2020
In #11191, we split up the running of the cfnspec update and the adding files to git/commit step into sub-shells However, variable assignments do not remain in effect after the subshell completes. Currently, the `version` variable is not accessible when we try to commit to Git. Removed the execution of these steps in sub-shells as the separation is not likely to provide a ton of benefit. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is transitively required when creating missing libraries in the
mono-repository. Use a manual
lernainvocation instead ofbuildupin order to avoid possibly re-building some dependencies.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license