feat(aws-codebuild): add support for secondary sources and artifact in Projects #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinny85
commented
Nov 9, 2018
|
@eladb ping :) |
|
@eladb ping ping when you have some time :) |
rix0rrr
approved these changes
Nov 15, 2018
…in Projects. This also adds support for multiple input and output artifacts in the CodeBuild CodePipeline Actions. BREAKING CHANGE: this changes the way CodeBuild Sources are constructed (we moved away from multiple parameters in the constructor, in favor of the more idiomatic property interface).
skinny85
force-pushed
the
feature/codebuild-secondary-sources-artifacts
branch
from
7fbf9b7
to
016d40e
Compare
|
Incorporated @rix0rrr 's comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds support for multiple input and output artifacts in the CodeBuild
CodePipeline Actions.
BREAKING CHANGE: this changes the way CodeBuild Sources are constructed
(we moved away from multiple parameters in the constructor,
in favor of the more idiomatic property interface).
Fixes #738.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.