Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integ): revert run all CDK integ tests with -v #10511

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Sep 24, 2020

Reverts #10503

We can't actually do this. There are tests that check that the output of the cdk command is exactly "some value", and adding the logging in breaks the expectation.

Revert the -v to allow the tests to go back to passing 90% of the time.

@rix0rrr rix0rrr requested a review from a team September 24, 2020 13:17
@rix0rrr rix0rrr self-assigned this Sep 24, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 24, 2020
@rix0rrr rix0rrr changed the title chore(integ): revert: run all CDK integ tests with -v chore(integ): revert run all CDK integ tests with -v Sep 24, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8ec1cfe into master Sep 24, 2020
@mergify mergify bot deleted the revert-10503-huijbers/verbose-integ branch September 24, 2020 13:43
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3708d4f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants