Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): add extra abstract properties to base classes to fix the build #10502

Merged
merged 1 commit into from
Sep 24, 2020
Merged

chore(rds): add extra abstract properties to base classes to fix the build #10502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/@aws-cdk/aws-rds/lib/cluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,9 @@ interface DatabaseClusterBaseProps {
* A new or imported clustered database.
*/
export abstract class DatabaseClusterBase extends Resource implements IDatabaseCluster {
// only required because of JSII bug: https://github.com/aws/jsii/issues/2040
public abstract readonly engine?: IClusterEngine;

/**
* Identifier of the cluster
*/
Expand Down
3 changes: 3 additions & 0 deletions packages/@aws-cdk/aws-rds/lib/instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ export abstract class DatabaseInstanceBase extends Resource implements IDatabase
public abstract readonly dbInstanceEndpointAddress: string;
public abstract readonly dbInstanceEndpointPort: string;
public abstract readonly instanceEndpoint: Endpoint;
// only required because of JSII bug: https://github.com/aws/jsii/issues/2040
public abstract readonly engine?: IInstanceEngine;
protected abstract enableIamAuthentication?: boolean;

/**
Expand Down Expand Up @@ -1096,6 +1098,7 @@ export class DatabaseInstanceReadReplica extends DatabaseInstanceNew implements
public readonly dbInstanceEndpointAddress: string;
public readonly dbInstanceEndpointPort: string;
public readonly instanceEndpoint: Endpoint;
public readonly engine?: IInstanceEngine = undefined;
protected readonly instanceType: ec2.InstanceType;

constructor(scope: Construct, id: string, props: DatabaseInstanceReadReplicaProps) {
Expand Down