Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The pathPatterns prop should be handled when calling addTargetGroups on ImportedApplicationListener #7303

Closed
2 tasks
vukers opened this issue Apr 10, 2020 · 1 comment · Fixed by #7305
Closed
2 tasks

The pathPatterns prop should be handled when calling addTargetGroups on ImportedApplicationListener #7303

vukers opened this issue Apr 10, 2020 · 1 comment · Fixed by #7305
Assignees
@rix0rrr
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@vukers
Copy link

vukers commented Apr 10, 2020

There was a recent feature added to allow for an array of pathPatterns to be used when calling addTargetGroupson ApplicationListener. This should also be applied to ImportedApplicationListener.

Use Case

So I can add multiple pathPatterns to an imported application listener.

Proposed Solution

Pass pathPatterns property to ApplicationListenerRule contructor.

https://github.com/DerkSchooltink/aws-cdk/blob/fdfd48ef691a994d616d282740fce6d487597ff2/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-listener.ts#L492

Other

Original issue: #6497
Original pull request: #6558
Suggested link to line: https://github.com/DerkSchooltink/aws-cdk/blob/fdfd48ef691a994d616d282740fce6d487597ff2/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-listener.ts#L492

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@vukers vukers added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 10, 2020
@DerkSchooltink
Copy link
Contributor

DerkSchooltink commented Apr 10, 2020 •
edited
Loading

Give me a few minutes and I will submit the PR! :)

@DerkSchooltink DerkSchooltink mentioned this issue Apr 10, 2020
Merged
@SomayaB SomayaB added the @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing label Apr 11, 2020
@mergify mergify bot closed this as completed in #7305 Apr 14, 2020
mergify bot pushed a commit that referenced this issue Apr 14, 2020
@DerkSchooltink
fix(elbv2): imported LoadBalancer ignores pathPatterns prop
8ed2e0c 
Fixes #7303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(elbv2): imported LoadBalancer ignores pathPatterns prop DerkSchooltink/aws-cdk
4 participants
@rix0rrr @vukers @DerkSchooltink @SomayaB