cdk deploy incorrect parsing of --parameters

[mikayzo]

When using:

cdk deploy --no-execute --parameters 'aws-stuff:OpsGenieSubscriptionEndpoint=https://api.eu.opsgenie.com/v1/json/cloudwatch?apiKey=some-random-key' '*'

I expect CDK to create a Change Set in my stack with parameter: OpsGenieSubscriptionEndpoint and its value: https://api.eu.opsgenie.com/v1/json/cloudwatch?apiKey=some-random-key

What I get instead is parameter: OpsGenieSubscriptionEndpoint and its value https://api.eu.opsgenie.com/v1/json/cloudwatch?apiKey

I found this issue in the code and here is an example of how it works:

current code:

const parameterMap: { [name: string]: string | undefined } = {};

let parameter = "aws-stuff:OpsGenieSubscriptionEndpoint=https://api.eu.opsgenie.com/v1/json/cloudwatch?apiKey=some-random-key";

if (typeof parameter === 'string') {
    const keyValue = (parameter as string).split('=');
    parameterMap[keyValue[0]] = keyValue[1];
    console.log(parameterMap)
}

output:

[LOG]: { "aws-stuff:OpsGenieSubscriptionEndpoint": "https://api.eu.opsgenie.com/v1/json/cloudwatch?apiKey" } 

how it should work:

const parameterMap: { [name: string]: string | undefined } = {};

let parameter = "aws-stuff:OpsGenieSubscriptionEndpoint=https://api.eu.opsgenie.com/v1/json/cloudwatch?apiKey=some-random-key";

if (typeof parameter === 'string') {
    const keyValue = (parameter as string).split('=');
    parameterMap[keyValue[0]] = keyValue.slice(1).join("=");
    console.log(parameterMap)
}

output:

[LOG]: { "aws-stuff:OpsGenieSubscriptionEndpoint": "https://api.eu.opsgenie.com/v1/json/cloudwatch?apiKey=some-random-key" } 

Reproduction Steps

1. Pass a parameter which has multiple = symbols when using: cdk deploy --parameters '' command, e.g, cdk deploy --parameters 'parameterKey=parameterValue=partOfValue=anotherPartOfValue'

Error Log

None, I only see incorrect parameter input in AWS.

Environment

• CLI Version :

$ cdk --version
1.31.0 (build 8f3ac79)

• Framework Version:
• OS :

macOS Catalina
version 10.15.4

• Language :

Other

Suggested fix: #7226

---

This is 🐛 Bug Report