Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VpcPlacementStrategy/import/export to also include Isolated subnets #597

Closed
rix0rrr opened this issue Aug 17, 2018 · 0 comments · Fixed by #610
Closed

Update VpcPlacementStrategy/import/export to also include Isolated subnets #597

rix0rrr opened this issue Aug 17, 2018 · 0 comments · Fixed by #610

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 17, 2018 •
edited
Loading

  • VPCPlacementStrategy at the moment does not allow placing instances inside isolated subnets.
  • VPC export/import ignores isolated subnets as well.
@rix0rrr rix0rrr changed the title Update VpcPlacementStrategy to also allow selecting Isolated subnets Update VpcPlacementStrategy/import/export to also include Isolated subnets Aug 20, 2018
rix0rrr pushed a commit that referenced this issue Aug 20, 2018
fix(aws-ec2): VPC properly uses complex subnet config
319e0cc 
It is now possible to pick Isolated subnets for the VPC placement
strategy. Also, Isolated subnets are properly exported and imported
using the VPC export()/import() functions, and it's now possible
not have all three of public/private/isolated subnets in the
export/import.

Fixes #597.
@rix0rrr rix0rrr mentioned this issue Aug 20, 2018
Merged
rix0rrr added a commit that referenced this issue Sep 9, 2018
@rix0rrr
fix(aws-ec2): VPC supports isolated subnets (#610)
27cbe2b 
It is now possible to pick Isolated subnets for the VPC placement
strategy. Also, Isolated subnets are properly exported and imported
using the VPC export()/import() functions, and it's now possible
not have all three of public/private/isolated subnets in the
export/import.

Fixes #597.

ALSO IN THIS COMMIT

To increase my confidence in the refactor, cfnts has been changed
to emit a distinct private field for every generated strongly-typed
CloudFormation instrinsic class. This makes it so that TypeScript
no longer considers those classes structurally the same, and so
substitution mistakes that lead to ClassCastExceptions in strongly-
typed languages can no longer happen. This flushed out a number
of places where we were still doing that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws-ec2): VPC properly uses complex subnet config aws/aws-cdk
1 participant
@rix0rrr