Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support setting environment variables on aws codebuild jobs from codepipline #4531

Closed
2 tasks
rvdwijngaard opened this issue Oct 16, 2019 · 1 comment · Fixed by #4502
Closed
2 tasks

support setting environment variables on aws codebuild jobs from codepipline #4531

rvdwijngaard opened this issue Oct 16, 2019 · 1 comment · Fixed by #4502
Assignees
@skinny85
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@rvdwijngaard
Copy link

Support environment variables for aws codebuild jobs from codepipeline.
https://aws.amazon.com/about-aws/whats-new/2019/10/aws-codepipeline-enables-setting-environment-variables-on-aws-codebuild-build-jobs/

Use Case

Reusing codebuild projects

Proposed Solution

extend @aws-cdk/aws-codepipeline-actions

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@rvdwijngaard rvdwijngaard added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 16, 2019
@skinny85
Copy link
Contributor

Already in PR in #4502 :)

@SomayaB SomayaB added in-progress This issue is being actively worked on. @aws-cdk/aws-codepipeline Related to AWS CodePipeline and removed needs-triage This issue or PR still needs to be triaged. labels Oct 16, 2019
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Oct 23, 2019
@skinny85
feat(codepipeline): add ability to override env variables in CodeBuil…
48f4209 
…d actions

Previously, environment variables were always defined on the CodeBuild project level,
which made it difficult to re-use the same project in the pipeline.
Now, you can specify environment variables on the CodeBuild action level,
which will override any project-level settings.

Fixes aws#4531
@skinny85 skinny85 mentioned this issue Oct 23, 2019
Merged
skinny85 added a commit that referenced this issue Oct 23, 2019
@skinny85
feat(codepipeline): add ability to override env variables in CodeBuil…
c0c0513 
…d actions (#4502)

Previously, environment variables were always defined on the CodeBuild project level,
which made it difficult to re-use the same project in the pipeline.
Now, you can specify environment variables on the CodeBuild action level,
which will override any project-level settings.

Fixes #4531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codepipeline): add ability to override env variables in CodeBuild actions skinny85/aws-cdk
3 participants
@skinny85 @rvdwijngaard @SomayaB