Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"cdk diff" doesn't take the CDK::Metadata resource into account #422

Closed
eladb opened this issue Jul 27, 2018 · 0 comments · Fixed by #435 · May be fixed by SNYKabbott/aws-cdk#18 or SNYKabbott/aws-cdk#19
Closed

"cdk diff" doesn't take the CDK::Metadata resource into account #422

eladb opened this issue Jul 27, 2018 · 0 comments · Fixed by #435 · May be fixed by SNYKabbott/aws-cdk#18 or SNYKabbott/aws-cdk#19
Assignees
@RomainMuller

Comments

@eladb
Copy link
Contributor

eladb commented Jul 27, 2018

So it always shows as if it is going to be added to the stack
RomainMuller added a commit that referenced this issue Jul 30, 2018
@RomainMuller
Correctly account for CDK::Metadata resource in cdk diff`
62e029f 
The arguments to the diff function were passed incorrectly, resulting in
the version tracking information not being forwarded correctly to
synthesizeTemplate.

Fixes #422
@RomainMuller RomainMuller mentioned this issue Jul 30, 2018
Merged
RomainMuller added a commit that referenced this issue Jul 30, 2018
@RomainMuller
Correctly account for CDK::Metadata resource in cdk diff` (#435)
5a1a277 
The arguments to the diff function were passed incorrectly, resulting in
the version tracking information not being forwarded correctly to
synthesizeTemplate.

Fixes #422
This was referenced Apr 24, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@RomainMuller @eladb