Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2: Security Group Peer CIDR validation #3639

Closed
1 of 5 tasks
nmussy opened this issue Aug 13, 2019 · 0 comments · Fixed by #3642
Closed
1 of 5 tasks

EC2: Security Group Peer CIDR validation #3639

nmussy opened this issue Aug 13, 2019 · 0 comments · Fixed by #3642
Assignees
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud feature-request A feature should be added or improved.

Comments

@nmussy
Copy link
Contributor

nmussy commented Aug 13, 2019

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.
  • What is the current behavior?
    If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce
    Peer.ipv4 and Peer.ipv6 do not throw when given an invalid CIDR block. The error only happens when deploying the stack.

  • What is the expected behavior (or behavior of feature suggested)?
    The parameter should be regex matched, and an error should be thrown if the provided parameter is not a valid CIDR. Ideally, the CDK could also match a plain IP without the mask, and throw a different error, suggesting adding it, e.g. did you mean 0.0.0.0/0, or 255.255.255.255/24?.

  • What is the motivation / use case for changing the behavior or adding this feature?
    The naming of the Peer.ipv4/v6 methods is misleading, and I keep forgetting that the parameter must be a CIDR.

  • Please tell us about your environment:

    • CDK CLI Version: 1.3.0
    • Module Version: 1.3.0
    • OS: all
    • Language: all
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

@nmussy nmussy added the needs-triage This issue or PR still needs to be triaged. label Aug 13, 2019
@NGL321 NGL321 added feature-request A feature should be added or improved. @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud and removed needs-triage This issue or PR still needs to be triaged. labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants