Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinesis Stream permissions missing ListShards #3357

Closed
1 task done
ghost opened this issue Jul 19, 2019 · 1 comment · Fixed by #6141
Closed
1 task done

Kinesis Stream permissions missing ListShards #3357

ghost opened this issue Jul 19, 2019 · 1 comment · Fixed by #6141
Assignees
@iliapolo
Labels
@aws-cdk/aws-kinesis Related to Amazon Kinesis effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.

Comments

@ghost
Copy link

ghost commented Jul 19, 2019

  • I'm submitting a ...

    • 📚 construct library gap

  • What is the current behavior?
    Stream.grantRead doesn't grant the ListShards permission, which is useful for Kinesis Client Library v2 among other things.

Stream also doesn't offer a custom .grant(Grantable, List<String>) to allow an easy workaround.
@ghost ghost added the needs-triage This issue or PR still needs to be triaged. label Jul 19, 2019
@skinny85 skinny85 added feature-request A feature should be added or improved. gap @aws-cdk/aws-kinesis Related to Amazon Kinesis and removed needs-triage This issue or PR still needs to be triaged. labels Aug 15, 2019
@reillykw
Copy link
Contributor

reillykw commented Feb 6, 2020 •
edited
Loading

#6141 should close this issue

@skinny85 skinny85 assigned iliapolo and unassigned skinny85 Feb 6, 2020
@SomayaB SomayaB removed the gap label Feb 25, 2020
@iliapolo iliapolo added the effort/small Small work item – less than a day of effort label Mar 9, 2020
@reillykw reillykw mentioned this issue Mar 12, 2020
Merged
@mergify mergify bot closed this as completed in #6141 Apr 8, 2020
mergify bot pushed a commit that referenced this issue Apr 8, 2020
@reillykw
feat(kinesis): grantRead now allows the ListShards action and `gr…
563fba4 
…ant` is now public (#6141)

`grant()` method on the class is private, preventing custom actions on attached policy. This makes that public.

`grantRead()` API now has `ListShards`, `DescribeStreamSummary`, or `SubscribeToShard` permissions

`grantWrite()` API no longer has `DescribeStream` permissions as it has been replaced by `ListShards` for shard discovery.
Rationale: Align with the [Kinesis Producer Library](https://aws.amazon.com/about-aws/whats-new/2019/11/amazon-kinesis-producer-library-now-supports-listshards-api-for-efficient-scaling-of-producer-applications/)

Closes #3357

BREAKING CHANGE: 
`grantWrite()` API no longer has `DescribeStream` permissions as it has been replaced by `ListShards` for shard discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iliapolo iliapolo

Labels
@aws-cdk/aws-kinesis Related to Amazon Kinesis effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(kinesis): grantRead now allows the ListShards action and grant is now public reillykw/aws-cdk
4 participants
@skinny85 @iliapolo @SomayaB @reillykw