Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codepipeline-v2): start codepipeline v2 #33511

Open
2 tasks done
jaecktec opened this issue Feb 19, 2025 · 6 comments
Open
2 tasks done

feat(codepipeline-v2): start codepipeline v2 #33511

jaecktec opened this issue Feb 19, 2025 · 6 comments
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@jaecktec
Copy link
Contributor

jaecktec commented Feb 19, 2025 •
edited
Loading

Describe the feature

I'd like to advertise for codepipeline v2 construct.
Since there were some attempts to add v2 features to the current construct, none of them were successful or even rolled back.

The idea is to have an issue we can follow and maybe link some draft PRs so we can discuss the best outcome.

Related issues and comments

Feel free to add more features you like to see in the 'new V2' construct

Features

Use Case

Support V2 Pipeline features in a convenient way

Proposed Solution

Create a V2 construct that is heavily inspired by the existing Pipeline construct - but extends the required features.

Maybe:
For cleanup we could roll back #29134 to make clear that the current one is the V1 construct and the new one is V2 so that migration should be a replacement of the Construct not a property.

Other Information

While I would be happy to extend the existing construct I can also see the argument for creating a V2 construct.

Also we probably want to have this as an alpha - I couln't find the docs on how to create an alpha module, so I'd request some help from the maintainers for this :)

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.197.0
@jaecktec jaecktec added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 19, 2025
@github-actions github-actions bot added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label Feb 19, 2025
@jaecktec jaecktec changed the title codepipeline: start codepipeline v2 feat(codepipeline-v2): start codepipeline v2 Feb 19, 2025
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Feb 19, 2025
@pahud
Copy link
Contributor

pahud commented Feb 20, 2025

I guess this might need a RFC. I'm bringing it up to the team for inputs.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 20, 2025
@hwum
Copy link
Contributor

hwum commented Feb 24, 2025

Hi there,
We're working on that. Will send a PR soon.

Codepipeline dev

@hwum hwum mentioned this issue Feb 27, 2025
Closed
@github-actions github-actions bot mentioned this issue Mar 1, 2025
Open
@driverpt
Copy link

Any ETA on this one ?

@hwum
Copy link
Contributor

hwum commented Mar 13, 2025

Sorry no clear ETA on this. Already in review process. Will post the update once the review gets approved. But I assume it will be delivered in a few days

This was referenced Mar 14, 2025
Closed
Merged
mergify bot pushed a commit that referenced this issue Mar 21, 2025
@hwum
feat(codepipeline): stage level condition feature L2 construct (#33809)
8e4374f 
### Issue # (if applicable)
#33511

### Reason for this change
Codepipeline launched this feature last years and still missed the update in cdk library.

### Description of changes

Support this feature in L2 Construct:https://docs.aws.amazon.com/codepipeline/latest/userguide/concepts-how-it-works-conditions.html

### Describe any new or updated permissions being added

No


### Description of how you validated changes

Unit test, integ test, and local cdk library deployment(linked to local cdkApp and successfully deploy it)

### Checklist
- [Y ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@hwum
Copy link
Contributor

hwum commented Mar 24, 2025

Hi community,
Currently we're working on the feature listed above added to current construct, and we don't have clear plan of creating new construct instead now. Codepipeline V1 and V2 are totally compatible, compared to V1, Codepipeline V2 has additional properties, and it's not worth to create new cdk construct instead of adding missing feature into current cdk construct.
However, we're open to more ideas. Please send us rfc if you have ideas about how the cdk V2 construct looks like, and we'll discuss with cdk team about this.
Cheers,
Codepipeline dev

@hwum
Copy link
Contributor

hwum commented Mar 26, 2025

The features listed above now are available in aws-codepipeline lib. Please feel free to reach out to us if you have more ideas about V2 construct.
Cheers,
Codepipeline dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pahud @driverpt @jaecktec @hwum