Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(devcontainer): missing git-lfs #33461

Closed
1 task
phuhung273 opened this issue Feb 15, 2025 · 3 comments · Fixed by #33468
Closed
1 task

(devcontainer): missing git-lfs #33461

phuhung273 opened this issue Feb 15, 2025 · 3 comments · Fixed by #33468
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p3 package/tools Related to AWS CDK Tools or CLI

Comments

@phuhung273
Copy link
Contributor

phuhung273 commented Feb 15, 2025 •
edited by pahud
Loading

Describe the bug

This blocks devcontainer user from pushing commit

This repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting the 'pre-push' file in the hooks directory (set by 'core.hookspath'; usually '.git/hooks').

error: failed to push some refs to 'github.com:phuhung273/aws-cdk.git'

Manually install git-lfs fix the issue. Before we didn't need to do that.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

git-lfs preinstalled in devcontainer

Current Behavior

No git-lfs in devcontainer

Reproduction Steps

Open main branch in devcontainer

Possible Solution

Preinstall git-lfs in devcontainer

Additional Information/Context

Manually install git-lfs fix the issue

CDK CLI Version

main

Framework Version

No response

Node.js Version

v20.18.1

OS

devcontainer

Language

TypeScript

Language Version

No response

Other information

No response
@phuhung273 phuhung273 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 15, 2025
@github-actions github-actions bot added potential-regression Marking this issue as a potential regression to be checked by team member package/tools Related to AWS CDK Tools or CLI labels Feb 15, 2025
@pahud
Copy link
Contributor

pahud commented Feb 15, 2025

Yeah I guess we need to update Dockerfile or devcontainer configuration.

We welcome PRs.

@pahud pahud added p3 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. potential-regression Marking this issue as a potential regression to be checked by team member labels Feb 15, 2025
@yasuaki640 yasuaki640 mentioned this issue Feb 16, 2025
Merged
1 task
@mergify mergify bot closed this as completed in #33468 Feb 16, 2025
@mergify mergify bot closed this as completed in 4b0094b Feb 16, 2025
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2025
yashkh-amzn pushed a commit to yashkh-amzn/aws-cdk that referenced this issue Feb 21, 2025
@yasuaki640 @yashkh-amzn
chore: install git lfs in dev container (aws#33468)
d8f90c2 
### Issue # (if applicable)

Closes aws#33461 .

### Reason for this change

Because git lfs is not installed in devcontainer.

### Description of changes

install git lfs on dev container.

### Describe any new or updated permissions being added




### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p3 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: install git lfs in dev container yasuaki640/aws-cdk
2 participants
@pahud @phuhung273