TypeScript ECR Documentation Update #3273
Assignees
Labels
@aws-cdk/aws-ecr
Related to Amazon Elastic Container Registry
docs/guide
Related to the developer guide
feature-request
A feature should be added or improved.
good first issue
Related to contributions. See CONTRIBUTING.md
Comments
mergify bot
pushed a commit
that referenced
this issue
Dec 16, 2019
* docs(ecr): fix deprecated requirement maxImageAgeDays - on [Automatically clean up repositories](https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecr-readme.html\#automatically-clean-up-repositories) of Amazon ECR docs, there is deprecated property using on addLifecycleRule example - due to introduce of Duration Class(#2857), it should be maxImageAge rather than maxImageAgeDays * chore(ecr): fix deprecated requirement maxImageAgeDays - maxImageAgeDays were deprecated since #2857, but still used on comments. - should be chaged to maxImageAge - fixes #3273
ed-at-work
pushed a commit
to ed-at-work/aws-cdk
that referenced
this issue
Dec 17, 2019
* docs(ecr): fix deprecated requirement maxImageAgeDays - on [Automatically clean up repositories](https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecr-readme.html\#automatically-clean-up-repositories) of Amazon ECR docs, there is deprecated property using on addLifecycleRule example - due to introduce of Duration Class(aws#2857), it should be maxImageAge rather than maxImageAgeDays * chore(ecr): fix deprecated requirement maxImageAgeDays - maxImageAgeDays were deprecated since aws#2857, but still used on comments. - should be chaged to maxImageAge - fixes aws#3273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.
I'm submitting a ...
What is the current behavior?
If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce
https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecr-readme.html has
repository.addLifecycleRule({ maxImageAgeDays: 30 });but using maxImageAgeDays returns an error.
Argument of type '{ maxImageAgeDays: number; }' is not assignable to parameter of type 'LifecycleRule'. Object literal may only specify known properties, and 'maxImageAgeDays' does not exist in type 'LifecycleRule'.What is the expected behavior (or behavior of feature suggested)?
repository.addLifecycleRule({ maxImageAge: cdk.Duration.days(30) });
What is the motivation / use case for changing the behavior or adding this feature?
Please tell us about your environment:
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)
The text was updated successfully, but these errors were encountered: