cli: everywhere we use a waiter we have to adjust the message to take waiter errors into account #32481
Assignees
Labels
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p1
package/tools
Related to AWS CDK Tools or CLI
Comments
rix0rrr
added
feature-request
1 task
ashishdhingra
added
p2
investigating
|
Opened by CDK team. Marking it as |
ashishdhingra
added
effort/medium
This was referenced Jan 1, 2025
otaviomacedo
added a commit
that referenced
this issue
Jan 22, 2025
Waiter errors now have an additional piece of information: the responses that were observed during the polling, and their counts. Relay this information to the user in the error message. Closes #32481. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. |
moelasmar
pushed a commit
that referenced
this issue
Jan 24, 2025
Waiter errors now have an additional piece of information: the responses that were observed during the polling, and their counts. Relay this information to the user in the error message. Closes #32481. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit b512a72)
moelasmar
pushed a commit
that referenced
this issue
Jan 24, 2025
Waiter errors now have an additional piece of information: the responses that were observed during the polling, and their counts. Relay this information to the user in the error message. Closes #32481. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit b512a72)
moelasmar
pushed a commit
that referenced
this issue
Jan 24, 2025
Waiter errors now have an additional piece of information: the responses that were observed during the polling, and their counts. Relay this information to the user in the error message. Closes #32481. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit b512a72)
moelasmar
pushed a commit
that referenced
this issue
Jan 24, 2025
Waiter errors now have an additional piece of information: the responses that were observed during the polling, and their counts. Relay this information to the user in the error message. Closes #32481. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit b512a72)
moelasmar
pushed a commit
that referenced
this issue
Jan 24, 2025
Waiter errors now have an additional piece of information: the responses that were observed during the polling, and their counts. Relay this information to the user in the error message. Closes #32481. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit b512a72)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the feature
This PR smithy-lang/smithy-typescript#1467 changed the information that is contained in an error thrown from a waiter.
We must include the additional error detail in the message we print to the screen.
Use Case
If we do not, permissions errors are invisible.
While we're at it, see also: #32237
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
Environment details (OS name and version, etc.)
The text was updated successfully, but these errors were encountered: