Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IoHost logger-only implementation #32345

Closed
mrgrain opened this issue Dec 1, 2024 · 2 comments · Fixed by #32503
Closed

IoHost logger-only implementation #32345

mrgrain opened this issue Dec 1, 2024 · 2 comments · Fixed by #32503
Assignees
Labels

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Dec 1, 2024

From the RFC implement a private CliIoHost class that satisfies the notify(...) method of the interface and required message interfaces.

interface IIoHost {
  /**
   * Notifies the host of a message.
   * The caller waits until the notification completes.
   */
  notify<T>(msg: IoMessage<T>): Promise<void>;
}

The implementation should follow the existing logging implementation. However this ticket will not change any existing functionality.

  • You don't need to have an interface just the implementations.
  • Create IoMessage except for the data property
  • Add all code to new files into a new toolkit subdirectory in the cli package.
  • None of these classes and files should be exported.
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
iankhou pushed a commit that referenced this issue Jan 13, 2025
### Issue #32345

Closes #32345

### Reason for this change

Setting the ground work for our [Programmatic Toolkit](aws/aws-cdk-rfcs#654)

### Description of changes

Created an unconnected CLIIoHost with a singular initial action available `notify`. In this implementation of the soon to be defined IoHost we are only writing logs to stdout and stderr.

### Description of how you validated changes

Verified via unit testing as this is currently unconnected to the greater AWS CDK CLI

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants