Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs: support new versionConsistency on container definitions #32202

Closed
2 tasks
isker opened this issue Nov 19, 2024 · 4 comments · Fixed by #32225
Closed
2 tasks

ecs: support new versionConsistency on container definitions #32202

isker opened this issue Nov 19, 2024 · 4 comments · Fixed by #32225
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@isker
Copy link
Contributor

isker commented Nov 19, 2024 •
edited
Loading

Describe the feature

This new property is not present in the L2 constructs currently: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-containerdefinition.html#cfn-ecs-taskdefinition-containerdefinition-versionconsistency

More details: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/deployment-type-ecs.html#deployment-container-image-stability

Use Case

Need to turn the "version consistency" feature off on my ECS service deployments.

Proposed Solution

No response

Other Information

Refer to aws/containers-roadmap#2394 for myriad users' struggles since this feature was added to ECS a few months ago.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.167.2

Environment details (OS name and version, etc.)

N/A
@isker isker added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Nov 19, 2024
@isker
Copy link
Contributor Author

isker commented Nov 19, 2024 •
edited
Loading

This is in the L1 types in main as of #32175.

@isker
Copy link
Contributor Author

isker commented Nov 19, 2024 •
edited
Loading

One more complicated thing to consider might be disabling this feature by default for all containers that use a DockerImageAsset, though I don't know that that's possible even if it were agreeable. I think the semantics around DockerImageAsset tags are not in line with the problems this feature was designed to address, and the feature can thus produce needless latency added to ECS deployments of services that include DockerImageAsset containers.

@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 20, 2024
@khushail khushail self-assigned this Nov 20, 2024
@khushail
Copy link
Contributor

@isker , thanks for sharing the linked articles and information. I see that Cloudformation supports this and by default it's enabled -#32175. It might be a cause of concern to disable it , so it might require inputs from the Core team on how to proceed for PR contribution or if the team is already planning to get this available .

Marking it as P2 as it might be helpful to have but would need team's input on how should this be proceeded with these scenarios in mind. Requesting team to share their insights on this request as how this can be implemented

@khushail khushail removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Nov 20, 2024
@khushail khushail removed their assignment Nov 20, 2024
@khushail khushail added the effort/small Small work item – less than a day of effort label Nov 20, 2024
@isker isker mentioned this issue Nov 21, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
@kaizencc kaizencc added the good first issue Related to contributions. See CONTRIBUTING.md label Jan 9, 2025
@mergify mergify bot closed this as completed in #32225 Feb 3, 2025
mergify bot pushed a commit that referenced this issue Feb 3, 2025
@isker
feat(ecs): support container version consistency (#32225)
37df0d2 
### Issue # (if applicable)

Closes #32202.

### Reason for this change

Support the new ECS::TaskDefinition ContainerDefinition VersionConsistency property. This is a simple enabled/disabled flag.

### Description of changes

Add a simple enabled/disabled enum prop to the construct.

More consequentially, default the prop to disabled (instead of unset) if the container image is a CDK asset, for the reasons described in the comments.

### Description of how you validated changes

Unit and integration tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): support container version consistency isker/aws-cdk
3 participants
@isker @kaizencc @khushail