Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2: pricing api interface vpc endpoint duplicated #31911

Closed
1 task
mazyu36 opened this issue Oct 26, 2024 · 2 comments · Fixed by #31912
Closed
1 task

ec2: pricing api interface vpc endpoint duplicated #31911

mazyu36 opened this issue Oct 26, 2024 · 2 comments · Fixed by #31912
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Oct 26, 2024

Describe the bug

InterfaceVpcEndpointAwsService('pricing.api') enum duplicated.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts#L518

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts#L520

These are added in #31882 and #31907.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

Only one InterfaceVpcEndpointAwsService('pricing.api') enum exists.

Current Behavior

InterfaceVpcEndpointAwsService('pricing.api') enum duplicated.

Reproduction Steps

N/A

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

maybe not released yet

Framework Version

No response

Node.js Version

irrelevant

OS

irrelevant

Language

TypeScript

Language Version

No response

Other information

No response

@mazyu36 mazyu36 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 26, 2024
@mergify mergify bot closed this as completed in #31912 Oct 26, 2024
mergify bot pushed a commit that referenced this issue Oct 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
### Issue # (if applicable)

Closes #31911.

### Reason for this change
`InterfaceVpcEndpointAwsService('pricing.api')` enum duplicated.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts#L518
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts#L520



One side should be deleted.

### Description of changes

Delete the enum that was added later.



### Description of how you validated changes
nothing because only enum changed



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 28, 2024
@ashishdhingra
Copy link
Contributor

Issue closed by related PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants