Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pipelines): (Add feature to display all changesets for stage before manual approval step) #24072

Open
1 of 2 tasks
Nico-DB opened this issue Feb 8, 2023 · 4 comments
Open
1 of 2 tasks

(pipelines): (Add feature to display all changesets for stage before manual approval step) #24072

Nico-DB opened this issue Feb 8, 2023 · 4 comments
Labels
@aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@Nico-DB
Copy link

Nico-DB commented Feb 8, 2023

Describe the feature

I would like to "run" all changesets of a stage at first, then have a manual approval step and then perform the execute change set in the original run-order.

Use Case

The use case is, that we would like to check the changesets for all stacks of an environment, to be able to perform a qualified manual approval.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.63.2

Environment details (OS name and version, etc.)

Linux a-3pq6x6lu5kukl 5.15.86-53.137.amzn2.x86_64 #1
@Nico-DB Nico-DB added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 8, 2023
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Feb 8, 2023
@Nico-DB
Copy link
Author

Nico-DB commented Feb 8, 2023

@hoegertn

@tim-finnigan
Copy link

Hi @Nico-DB thanks for creating this feature request. Could you provide more details as far as your use case and what changes you're proposing? You are welcome to go ahead and create a PR, here is the Contributing guide for reference: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md. I can't guarantee that the team would consider implementing the changes you're proposing but it would help to have some code to review in order to better understand the proposed use case and solution.

@tim-finnigan tim-finnigan self-assigned this Feb 8, 2023
@tim-finnigan tim-finnigan added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 8, 2023
@Nico-DB
Copy link
Author

Nico-DB commented Feb 9, 2023

Hi @tim-finnigan ,

i have attached a picture showing the use-case i mentioned. This is done via the codepipeline construct.

Example-manual-approval

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Feb 9, 2023
@tim-finnigan
Copy link

Thanks for following up — if there is any more information anyone wants to share as far as use cases for this feature, please leave a comment here. Others can also 👍 the issue if interested in this feature.

@tim-finnigan tim-finnigan removed their assignment Mar 6, 2023
@Nico-DB Nico-DB mentioned this issue Apr 24, 2023
Closed
@Nico-DB Nico-DB mentioned this issue May 3, 2023
Closed
@Nico-DB Nico-DB mentioned this issue Jun 5, 2023
Closed
This was referenced Dec 18, 2023
Closed
Closed
@Nico-DB Nico-DB mentioned this issue Jul 1, 2024
Closed
@Nico-DB Nico-DB mentioned this issue Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pipelines): Add feature to display all changesets for stage before manual approval step + added postPrepare Step Nico-DB/aws-cdk
feat(pipelines): Add feature to display all changesets for stage before manual approval step + added postPrepare Step #25413 Nico-DB/aws-cdk
feat(pipelines): Add feature to display all changesets for stage before manual approval step + added postPrepare Step #25413 Nico-DB/aws-cdk
feat(pipelines): Add feature to display all changesets for stage before manual approval step + added postPrepare Step #25413 Nico-DB/aws-cdk
feat(pipelines): Add feature to display all changesets for stage before manual approval step + added postPrepare Step Nico-DB/aws-cdk
feat(pipelines): add feature to display all changesets for stage before manual approval step + added postPrepare Step Nico-DB/aws-cdk
2 participants
@Nico-DB @tim-finnigan