Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(sns): Allow delivery retry policy configuration of HTTPS subscription on SNS topic #17576

Open
2 tasks
kunalshah opened this issue Nov 18, 2021 · 3 comments · May be fixed by #30830
Open
2 tasks

(sns): Allow delivery retry policy configuration of HTTPS subscription on SNS topic #17576

kunalshah opened this issue Nov 18, 2021 · 3 comments · May be fixed by #30830
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@kunalshah
Copy link

Description

While creating HTTPS Subscription on SNS topic, there's no way to configure the retry policy.

Use Case

I am creating SNS topic and HTTPS subscription using CDK and want to provide custom delivery retry policy.

Proposed Solution

Update UrlSubscriptionProps interface to provide deliveryRetryPolicy as well.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@kunalshah kunalshah added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 18, 2021
@github-actions github-actions bot added the @aws-cdk/aws-sns Related to Amazon Simple Notification Service label Nov 18, 2021
@njlynch njlynch changed the title (module name): Allow delivery retry policy configuration of HTTPS subscription on SNS topic (sns): Allow delivery retry policy configuration of HTTPS subscription on SNS topic Dec 7, 2021
@njlynch
Copy link
Contributor

njlynch commented Dec 7, 2021

Thanks for the feature request.

While you're waiting for the feature, you can use escape hatches to set the underlying Cloudformation properties. (In this case, it looks like the Subscription DeliveryPolicy).

Relevant docs on the feature for reference: https://docs.aws.amazon.com/sns/latest/dg/sns-message-delivery-retries.html#creating-delivery-policy

@njlynch njlynch added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 7, 2021
@njlynch njlynch removed their assignment Dec 7, 2021
@fertrevino
Copy link

I just came across this use case, it would be neat it implemented

@dannellyz
Copy link

Also working this for being able to set the HTTP/S Content Header type via the topic CDK creation for those that have subscribers of multiple types. Thanks!

@pahud pahud added p2 and removed p1 labels Jun 11, 2024
@LaurenceWarne LaurenceWarne linked a pull request Jul 11, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sns): add delivery policy to sns subscriptions LaurenceWarne/aws-cdk
5 participants
@pahud @njlynch @kunalshah @dannellyz @fertrevino