Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(synthetics): support SSE-S3 and SSE-KMS to encrypt canary artifacts #30190

Closed
1 of 2 tasks
mazyu36 opened this issue May 14, 2024 · 3 comments · Fixed by #30197
Closed
1 of 2 tasks

(synthetics): support SSE-S3 and SSE-KMS to encrypt canary artifacts #30190

mazyu36 opened this issue May 14, 2024 · 3 comments · Fixed by #30197
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented May 14, 2024

Describe the feature

CloudWatch Synthetics supports SSE-S3 and SSE-KMS to encrypt artifacts.
https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_artifact_encryption.html

But in the current Canary Construct, we cannot choose encryption options.

Use Case

To use the SSE-S3 or SSE-KMS option.

Proposed Solution

Add artifactConfig property to the Canary Construct.

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_synthetics.CfnCanary.ArtifactConfigProperty.html

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.141.0

Environment details (OS name and version, etc.)

MacOS
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 14, 2024
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label May 14, 2024
@pahud
Copy link
Contributor

pahud commented May 14, 2024

Thank you @mazyu36. We look forward to your PR as always.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 14, 2024
@mazyu36 mazyu36 mentioned this issue May 15, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue May 20, 2024
Closed
@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
@mergify mergify bot closed this as completed in #30197 Nov 6, 2024
@mergify mergify bot closed this as completed in 1f39cb9 Nov 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this issue Nov 13, 2024
@mazyu36
feat(synthetics): add artifactS3Encryption property to the Canary C…
454f8c6 
…onstruct. (aws#30197)

### Issue # (if applicable)

Closes aws#30190.

### Reason for this change
To select encryption options.



### Description of changes
Add `artifactS3Encryption` property to the Canary Construct.



### Description of how you validated changes
Add unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(synthetics): add artifactS3Encryption property to the Canary Construct. mazyu36/aws-cdk
2 participants
@pahud @mazyu36