-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lambda: Function.fromFunctionArn will strip off the trailing version or alias #30002
Labels
Comments
pahud
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Apr 29, 2024
1 task
mergify bot
pushed a commit
that referenced
this issue
Apr 29, 2024
…object" (#30003) ### Issue # (if applicable) Revert #29820 Closes #30002 ### Reason for this change ### Description of changes ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
moelasmar
pushed a commit
that referenced
this issue
Apr 29, 2024
…object" (#30003) ### Issue # (if applicable) Revert #29820 Closes #30002 ### Reason for this change ### Description of changes ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced May 1, 2024
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
This PR removed the trailing version or alias of the functionArn and is potentially causing breaking changes.
For example,
If Stack A exporting the functionArn like
arn:aws:lambda:us-east-1:123456789012:function:ProcessKinesisRecords:live
to Stack B and CDK from Stack B importing that withFunction.fromFunctionArn
, stack B would have the functionArn with the trailing version or alias stripped off, causing the breaking changes.Expected Behavior
fromFunctionArn() should not remove the trailing version or alias. We probably implement https://github.com/aws/aws-cdk/pull/29820/files with a feature flag.
Current Behavior
fromFunctionArn() would remove the trailing version or alias.
Reproduction Steps
as described above
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.138.0
Framework Version
No response
Node.js Version
all
OS
all
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: