(aws_rds): (Add Support for RDS Oracle 19.0.0.0.ru-2024-01.rur-2024-01.r1 and 21.0.0.0.ru-2024-01.rur-2024-01.r1 in OracleEngineVersion) #29360
Comments
ayushrawat007
added
feature-request
github-actions
bot
added
the
@aws-cdk/aws-rds
|
Yes we should add that into the enum-like class. |
pahud
added
p2
effort/small
|
@pahud I can take this |
|
I'm currently working on a tool to help detect these kinds of drifts (RDS engine versions, EC2 Windows images, etc.), by comparing the CDK code to SDK requests. For RDS, it's also checking whether a deprecated engine has been marked as such in TSDoc: 
It's just a CLI at the moment, but I'll probably end up turning it into a scheduled task, maybe even automate the opening of issues here if it's something you're interested in? |
### Issue # (if applicable) Closes #29360, closes #23810 **Note**: #29421 already adds some of the missing Oracle versions, this PR also includes them ### Reason for this change Update the CDK RDS engine versions to match the current availability, as well as facilitate automated alerts for updates in the future ### Description of changes * Added missing engine version for all RDS engines * This includes engines missing in the CDK that are already deprecated, but still returned by the SDK. The goal is to remove any differences between the two, even if it means a few needless static fields * Updated missing or un-needed `@deprecated` TSDoc tags ### Description of how you validated changes Like I mentioned in #29360 (comment), I'm working on a CLI that compares the `aws-cdk-lib` TypeScript declarations to SDK API calls, in this case `DescribeDBEngineVersions`. I am re-validating these locally edited files as I update them, until I have no differences between the CDK and the live SDK results. This is currently a mostly manual process. I'll add support for more version fields such as `ec2.WindowsVersion` before adding automation, to bridge the other currently missing versions ASAP. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Describe the feature
As per the RDS Doc: both RDS Oracle 19.0.0.0.ru-2024-01.rur-2024-01.r1 and 21.0.0.0.ru-2024-01.rur-2024-01.r1 are supported.
https://docs.aws.amazon.com/AmazonRDS/latest/OracleReleaseNotes/oracle-version-21-0.html#oracle-version-RU-RUR.21.0.0.0.ru-2024-01.rur-2024-01.r1
https://docs.aws.amazon.com/AmazonRDS/latest/OracleReleaseNotes/oracle-version-19-0.html#oracle-version-RU-RUR.19.0.0.0.ru-2024-01.rur-2024-01.r1
However the same is not reflected in the OracleEngineVersion class.
Hence requesting to add the support for the same.
Use Case
To be able to define RDS Oracle 19.0.0.0.ru-2024-01.rur-2024-01.r1 and 21.0.0.0.ru-2024-01.rur-2024-01.r1 via Static property value like the rest of the RDS Oracle versions.
Workaround: static of(oracleFullVersion, oracleMajorVersion) is know to us.
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
2.131.0
Environment details (OS name and version, etc.)
Mac
The text was updated successfully, but these errors were encountered: