Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route53: support latency based routing #28722

Closed
1 of 2 tasks
badmintoncryer opened this issue Jan 16, 2024 · 2 comments · Fixed by #28723
Closed
1 of 2 tasks

route53: support latency based routing #28722

badmintoncryer opened this issue Jan 16, 2024 · 2 comments · Fixed by #28723
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Jan 16, 2024 •
edited
Loading

Describe the feature

In Route 53, there is a latency-based routing feature. I want to implement this using CDK.

https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/routing-policy-latency.html

Use Case

In Cfn, this can be implemented by setting the region argument, but it cannot be implemented from L2.

Proposed Solution

Add region props to RecordSet and generate setIdentifier.

new RecordSet(scope, id, {
  ...  
  region: 'ap-northeast-1', // add
})

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.116.1

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-route53 Related to Amazon Route 53 label Jan 16, 2024
@badmintoncryer badmintoncryer mentioned this issue Jan 16, 2024
Merged
@pahud
Copy link
Contributor

pahud commented Jan 16, 2024

Thank you for the PR.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 16, 2024
@mergify mergify bot closed this as completed in #28723 Jan 24, 2024
mergify bot pushed a commit that referenced this issue Jan 24, 2024
@badmintoncryer
feat(route53): latency based routing (#28723)
169fd91 
In this PR, I have made the RecordSet compatible with latency-based routing.
You can set it by providing a Region name to the region argument.

```ts
new route53.ARecord(this, 'ARecord', {
  zone: myZone,
  target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
  region: 'ap-northeast-1', // added
})
```

Closes #28722.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

penniman26 pushed a commit to penniman26/aws-cdk that referenced this issue Jan 25, 2024
@badmintoncryer
feat(route53): latency based routing (aws#28723)
00121e9 
In this PR, I have made the RecordSet compatible with latency-based routing.
You can set it by providing a Region name to the region argument.

```ts
new route53.ARecord(this, 'ARecord', {
  zone: myZone,
  target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
  region: 'ap-northeast-1', // added
})
```

Closes aws#28722.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
SankyRed pushed a commit that referenced this issue Feb 8, 2024
@badmintoncryer @SankyRed
feat(route53): latency based routing (#28723)
c5571ba 
In this PR, I have made the RecordSet compatible with latency-based routing.
You can set it by providing a Region name to the region argument.

```ts
new route53.ARecord(this, 'ARecord', {
  zone: myZone,
  target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
  region: 'ap-northeast-1', // added
})
```

Closes #28722.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(route53): latency based routing badmintoncryer/aws-cdk
2 participants
@pahud @badmintoncryer