Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synthetics): graduate to stable 🚀 #27305

Merged
merged 8 commits into from
Sep 27, 2023
Merged

feat(synthetics): graduate to stable 🚀 #27305

merged 8 commits into from
Sep 27, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Sep 27, 2023

We are excited to graduate the @aws-cdk/aws-synthetics-alpha module to STABLE. It now lives on as aws-cdk-lib/aws-synthetics.

Deprecated properties removed:

  • Runtimes before SYNTHETICS_NODEJS_PUPPETEER_3_5 have been removed from the stable module. Use a later version instead.
  • enableAutoDeleteLambdas has been removed from the stable module. Use cleanup: Cleanup.LAMBDA instead, which achieves the same affect via custom resource.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 27, 2023 01:12
@github-actions github-actions bot added the p2 label Sep 27, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 27, 2023
@kaizencc kaizencc marked this pull request as ready for review September 27, 2023 03:23
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 27, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 349ded6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit dd00d05 into main Sep 27, 2023
17 checks passed
@mergify mergify bot deleted the conroy/stablesynth branch September 27, 2023 13:21
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot pushed a commit that referenced this pull request Oct 4, 2023
Synthetics was stabilized in #27305 and the alpha module was removed. Due to a bug in `align-versions.sh`, the last published `@aws-cdk/aws-synthetics-alpha` module relied on a peer dependency of `aws-cdk-lib@2.99.0` instead of `aws-cdk-lib@^2.99.0` (with the caret). This makes `@aws-cdk/aws-synthetics-alpha incompatible with later versions of aws-cdk-lib, and is unintentional.

#27376 fixes the bug in `align-versions.sh`, and this PR re-introduces `@aws-cdk/aws-synthetics-alpha` for one last version of CDK (v2.100.0) before we remove it again. This should have the effect of `@aws-cdk/aws-synthetics-alpha@2.100.0` being the last version of the alpha module, but still compatible with later versions of `aws-cdk-lib` by having the peer dependency `aws-cdk-lib@^2.100.0`. 

We still want users to migrate to the stable synthetics module at `aws-cdk-lib/aws-synthetics`, but we don't want to outright break existing users of the experimental module either.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants