Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ecs): add support for Amazon Linux 2023 in EcsOptimizedImage #26988

Closed
1 of 2 tasks
layertwo opened this issue Sep 3, 2023 · 2 comments · Fixed by #26989
Closed
1 of 2 tasks

(aws-ecs): add support for Amazon Linux 2023 in EcsOptimizedImage #26988

layertwo opened this issue Sep 3, 2023 · 2 comments · Fixed by #26989
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@layertwo
Copy link
Contributor

layertwo commented Sep 3, 2023

Describe the feature

Currently, the EcsOptimizedImage only provides hooks for Windows, Amazon Linux, and Amazon Linux 2. ECS is publishing a recommended ECS AMI for Amazon Linux 2023, however this is not implemented in the aws-ecs module.

Use Case

I want to launch ECS instances with the latest Amazon Linux 2023 AMI.

Proposed Solution

Expand EcsOptimizedImage to include a hook for Amazon Linux 2023. The same method for Amazon Linux and Amazon Linux 2 can be reapplied with a different ec2.AmazonLinuxGeneration.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.94.0

Environment details (OS name and version, etc.)

Ubuntu 22.04 LTS
@layertwo layertwo added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 3, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Sep 3, 2023
@layertwo layertwo mentioned this issue Sep 3, 2023
Merged
@pahud
Copy link
Contributor

pahud commented Sep 5, 2023 •
edited
Loading

Agree we should create a static method for EcsOptimizedImage? e.g.

EcsOptimizedImage.amazonLinux2023()

Thank you for the PR.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2023
@mergify mergify bot closed this as completed in #26989 Sep 9, 2023
mergify bot pushed a commit that referenced this issue Sep 9, 2023
@layertwo
feat(ecs): add Amazon Linux 2023 to EcsOptimizedImage (#26989)
0bac8a5 
Add support for selecting Amazon Linux 2023 ECS Optimized images.

Reference: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_AMI.html

Closes #26988.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mikewrighton pushed a commit that referenced this issue Sep 14, 2023
@layertwo
feat(ecs): add Amazon Linux 2023 to EcsOptimizedImage (#26989)
9bb7b11 
Add support for selecting Amazon Linux 2023 ECS Optimized images.

Reference: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_AMI.html

Closes #26988.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): add Amazon Linux 2023 to EcsOptimizedImage
2 participants
@pahud @layertwo