-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Number of stacks with differences" is wrong #26818
Comments
Yeah, I get
Here's the source code aws-cdk/packages/aws-cdk/lib/cdk-toolkit.ts Line 150 in 00a7f03
According to the PR, it was intending to print the number of stacks. So the solution here should probably be to actually accomplish that, rather than switch the wording to "resources" |
The current logic counts the number of changes in any parent stacks. It doesn't count nested stacks correctly, and doesn't count parent stacks correctly. With this change: <img width="1047" alt="Screenshot 2023-08-18 at 9 43 49 AM" src="https://github.com/aws/aws-cdk/assets/66279577/b417baa7-58d9-454a-a735-4bd406f1c126"> Without this change: <img width="1047" alt="Screenshot 2023-08-18 at 9 51 55 AM" src="https://github.com/aws/aws-cdk/assets/66279577/85e87e72-25ec-47af-96af-f47f7c43a4f2"> Closes #26818. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Describe the bug
WHen running cdk diff (and also "cdk deploy" I think), cdk produces this:
"Number of stacks with differences: xx". This is not correct. It should read "Number of resources with differences: xx"
Expected Behavior
the message should read "Number of resources with differences"
Current Behavior
The message reads: "Number of stacks with differences"
Reproduction Steps
just run cdk diff/deploy and look at the output
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.89.0
Framework Version
No response
Node.js Version
18.17
OS
Ubuntu 22
Language
Python
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: