Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ec2/iam): custom resources using Node16/SdkV2 #26708

Closed
MrArnoldPalmer opened this issue Aug 10, 2023 · 2 comments · Fixed by #26710
Closed

(ec2/iam): custom resources using Node16/SdkV2 #26708

MrArnoldPalmer opened this issue Aug 10, 2023 · 2 comments · Fixed by #26710
Assignees
@MrArnoldPalmer
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@MrArnoldPalmer
Copy link
Contributor

Describe the bug

The IAM OIDC and EC2 VPC restrict default security group custom resources still use Node16 and SdkV2. These weren't changed because they didn't use the builtInCustomResourceNodeRuntime mechanisms.

Expected Behavior

Use Node18 as the custom resources runtime which necessitates also using sdkv3 in the handler.

Current Behavior

Node16 is used.

Reproduction Steps

Provision these custom resources.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.90.0

Framework Version

No response

Node.js Version

18

OS

MacOS

Language

Typescript

Language Version

No response

Other information

No response
@MrArnoldPalmer MrArnoldPalmer added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 10, 2023
@MrArnoldPalmer MrArnoldPalmer self-assigned this Aug 10, 2023
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Aug 10, 2023
Merged
@Mahdi-Malekan
Copy link

There are other places which still using Node16
#26654
Please fix them all ✌️

@mergify mergify bot closed this as completed in #26710 Aug 11, 2023
mergify bot pushed a commit that referenced this issue Aug 11, 2023
@MrArnoldPalmer
fix(aws-cdk-lib): custom resources using Node16 and SDKv2 (#26710)
259a469 
Changes the IAM OIDC provider custom resource to use Node18 and SDKv3.

Changes the restrict-default-security-group custom resource to use
Node18 and sdkv3. Updates unit tests to use the mock client library for
easier mocking.

deployed integration test stacks for testing.

Closes #26708

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws-cdk-lib): custom resources using Node16 and SDKv2 aws/aws-cdk
2 participants
@MrArnoldPalmer @Mahdi-Malekan