cdk bootstrap prints "hotswap deployment skipped" when there is no diff

[rittneje]

Describe the bug

This appears to be the same issue as #24602 purported to fix. I guess it fixed it for normal stack deployments but not the bootstrap.

If we run cdk bootstrap and there are no changes, we now get a confusing message:

✨ hotswap deployment skipped - no changes were detected (use --force to override)

Expected Behavior

This message should not be displayed unless a hotswap was requested. (Is that even a thing for cdk bootstrap?)

It should simply say the same thing it used to.

✅ Environment aws://{account}/{region} bootstrapped (no changes).

Current Behavior

See above.

Reproduction Steps

Run cdk bootstrap twice for a given account/region.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.74.0 (build 70e2a33)

Framework Version

No response

Node.js Version

v18.16.0

OS

Alpine 3.17

Language

Python

Language Version

3.11.3

Other information

No response

[pahud]

Unfortunately I can't reproduce this. Does this issue still exist in the latest CDK version?

[rittneje]

@pahud This issue is still happening in v2.85.0.

+ cdk bootstrap --template cdk-bootstrap-template.yaml --profile bootstrap --trust {redacted} --cloudformation-execution-policies arn:aws:iam::aws:policy/AdministratorAccess --tags '{redacted}' --termination-protection --app cdk.out aws://{redacted}/us-east-1
Using bootstrapping template from cdk-bootstrap-template.yaml
 ⏳  Bootstrapping environment aws://{redacted}/us-east-1...
Trusted accounts for deployment: {redacted}
Trusted accounts for lookup: (none)
Execution policies: arn:aws:iam::aws:policy/AdministratorAccess

 ✨ hotswap deployment skipped - no changes were detected (use --force to override)

 ✅  Environment aws://{redacted}/us-east-1 bootstrapped (no changes).

[rittneje]

@pahud This issue is still happening in v2.99.1.

+ cdk bootstrap --template cdk-bootstrap-template.yaml --profile bootstrap --trust {redacted} --cloudformation-execution-policies arn:aws:iam::aws:policy/AdministratorAccess --tags '{redacted}' --termination-protection --app cdk.out aws://{redacted}/us-east-1
Using bootstrapping template from cdk-bootstrap-template.yaml
 ⏳  Bootstrapping environment aws://{redacted}/us-east-1...
Trusted accounts for deployment: {redacted}
Trusted accounts for lookup: (none)
Execution policies: arn:aws:iam::aws:policy/AdministratorAccess

 ✨ hotswap deployment skipped - no changes were detected (use --force to override)

 ✅  Environment aws://{redacted}/us-east-1 bootstrapped (no changes).

cc @peterwoodworth

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.